match: remove a mutable default argument

match: remove a mutable default argument

Mutable default arguments are know to the state of California to cause bugs.

--- a/mercurial/scmutil.py	Thu Sep 24 00:59:26 2015 -0700
+++ b/mercurial/scmutil.py	Thu Sep 24 01:00:05 2015 -0700
@@ -753,13 +753,15 @@
         ret.append(kindpat)
     return ret
 
-def matchandpats(ctx, pats=(), opts={}, globbed=False, default='relpath',
+def matchandpats(ctx, pats=(), opts=None, globbed=False, default='relpath',
                  badfn=None):
     '''Return a matcher and the patterns that were used.
     The matcher will warn about bad matches, unless an alternate badfn callback
     is provided.'''
     if pats == ("",):
         pats = []
+    if opts is None:
+        opts = {}
     if not globbed and default == 'relpath':
         pats = expandpats(pats or [])