changeset 25614:6c48f012d37e

phase: remove a 'for x in "foo bar".split()' idiom in phasecache.replace I find this idiom fairly horrible.
author Pierre-Yves David <pierre-yves.david@fb.com>
date Mon, 15 Jun 2015 16:06:17 -0700
parents a13c18c14ade
children dc707fb35550
files mercurial/phases.py
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/phases.py	Mon Jun 15 16:06:24 2015 -0700
+++ b/mercurial/phases.py	Mon Jun 15 16:06:17 2015 -0700
@@ -172,7 +172,7 @@
 
     def replace(self, phcache):
         """replace all values in 'self' with content of phcache"""
-        for a in 'phaseroots dirty opener _phaserevs _phasesets'.split():
+        for a in ('phaseroots', 'dirty', 'opener', '_phaserevs', '_phasesets'):
             setattr(self, a, getattr(phcache, a))
 
     def _getphaserevsnative(self, repo):