Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
getlogrevs: rewrite a loop to get read of try/except
authorPierre-Yves David <pierre-yves.david@fb.com>
Mon, 18 May 2015 12:18:00 -0500
changeset 25169 7855d1f5f152
parent 25168 4dfd4d3b9b93
child 25170 c69f4f7fe01a
getlogrevs: rewrite a loop to get read of try/except Get rid of the 'except StopIteration' abomination.
mercurial/cmdutil.py file | annotate | diff | comparison | revisions 
--- a/mercurial/cmdutil.py	Mon May 18 12:17:08 2015 -0500
+++ b/mercurial/cmdutil.py	Mon May 18 12:18:00 2015 -0500
@@ -2127,15 +2127,11 @@
         if not opts.get('rev'):
             revs.sort(reverse=True)
     if limit is not None:
-        count = 0
         limitedrevs = []
-        it = iter(revs)
-        while count < limit:
-            try:
-                limitedrevs.append(it.next())
-            except (StopIteration):
+        for idx, r in enumerate(revs):
+            if limit <= idx:
                 break
-            count += 1
+            limitedrevs.append(r)
         revs = revset.baseset(limitedrevs)
 
     return revs, expr, filematcher
Mercurial