changeset 41370:a728ef2f9b15

revpair: clarify check for empty revset Differential Revision: https://phab.mercurial-scm.org/D5688
author Martin von Zweigbergk <martinvonz@google.com>
date Thu, 24 Jan 2019 12:47:54 -0800
parents 5079242abef9
children 608c15f76f50
files mercurial/scmutil.py
diffstat 1 files changed, 3 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/scmutil.py	Thu Jan 24 12:38:19 2019 -0800
+++ b/mercurial/scmutil.py	Thu Jan 24 12:47:54 2019 -0800
@@ -672,11 +672,12 @@
 
     l = revrange(repo, revs)
 
+    if not l:
+        raise error.Abort(_('empty revision range'))
+
     first = l.first()
     second = l.last()
 
-    if first is None:
-        raise error.Abort(_('empty revision range'))
     if (first == second and len(revs) >= 2
         and not all(revrange(repo, [r]) for r in revs)):
         raise error.Abort(_('empty revision on one side of range'))