Mercurial > hg

changeset 45036:c05ac059749f

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cleanup: use any() instead of checking truthiness of temporary list It was not immediately obvious to me, when first seeing this, why a list was created. It needed a second look to understand that the purpose was to check whether the condition is true for any of the parents. Using any() for that is clearer.
author Manuel Jacob <me@manueljacob.de>
date Thu, 02 Jul 2020 02:46:15 +0200
parents 3862de62d5cf
children 0c40d2d151cb
files mercurial/cmdutil.py
diffstat 1 files changed, 3 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/cmdutil.py	Fri Jul 03 13:45:59 2020 +0530
+++ b/mercurial/cmdutil.py	Thu Jul 02 02:46:15 2020 +0200
@@ -3437,9 +3437,9 @@
         not opts.get(b'amend')
         and bheads
         and node not in bheads
-        and not [
-            x for x in parents if x.node() in bheads and x.branch() == branch
-        ]
+        and not any(
+            x.node() in bheads and x.branch() == branch for x in parents
+        )
     ):
         repo.ui.status(_(b'created new head\n'))
         # The message is not printed for initial roots. For the other