changeset 26597:d58721d684cb

discovery: reference relevant bug in the faulty code We extend the comment about this code flaw with more code flaw.
author Pierre-Yves David <pierre-yves.david@fb.com>
date Fri, 09 Oct 2015 15:44:00 -0700
parents 8688590ca03c
children 264e88901c44
files mercurial/discovery.py
diffstat 1 files changed, 3 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/discovery.py	Fri Oct 09 15:37:05 2015 -0700
+++ b/mercurial/discovery.py	Fri Oct 09 15:44:00 2015 -0700
@@ -320,6 +320,9 @@
             #
             # These two cases will be easy to handle for known changeset but
             # much more tricky for unsynced changes.
+            #
+            # In addition, this code is confused by prune as it only looks for
+            # successors of the heads (none if pruned) leading to issue4354
             newhs = set()
             for nh in candidate_newhs:
                 if nh in repo and repo[nh].phase() <= phases.public: