Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
test-histedit: $TESTTMP quoting fixes for Windows
authorMatt Harbison <matt_harbison@yahoo.com>
Sun, 22 Nov 2015 13:05:21 -0500
changeset 27062 e4f2e4f5e98d
parent 27061 9c75daf89450
child 27063 37e1fdcb271c
test-histedit: $TESTTMP quoting fixes for Windows Without this, C:\path\to\test is converted into C:pathtotest. Since $TESTTMP appears in output, seems to work in some places without quotes, and is also used within a larger quote block (see test-rebase-collapse.t, ~line 160), I'm not sure what a check-code rule would look like (or even if it is feasible).
tests/test-histedit-fold.t file | annotate | diff | comparison | revisions 
--- a/tests/test-histedit-fold.t	Sat Nov 21 23:26:22 2015 -0800
+++ b/tests/test-histedit-fold.t	Sun Nov 22 13:05:21 2015 -0500
@@ -524,13 +524,13 @@
   2:0e01aeef5fa8 foo1
   1:578c7455730c a
   0:79b99e9c8e49 b
-  $ cat > $TESTTMP/editor.sh <<EOF
-  > echo ran editor >> $TESTTMP/editorlog.txt
-  > cat \$1 >> $TESTTMP/editorlog.txt
-  > echo END >> $TESTTMP/editorlog.txt
+  $ cat > "$TESTTMP/editor.sh" <<EOF
+  > echo ran editor >> "$TESTTMP/editorlog.txt"
+  > cat \$1 >> "$TESTTMP/editorlog.txt"
+  > echo END >> "$TESTTMP/editorlog.txt"
   > echo merged foos > \$1
   > EOF
-  $ HGEDITOR="sh $TESTTMP/editor.sh" hg histedit 1 --commands - 2>&1 <<EOF | fixbundle
+  $ HGEDITOR="sh \"$TESTTMP/editor.sh\"" hg histedit 1 --commands - 2>&1 <<EOF | fixbundle
   > pick 578c7455730c 1 a
   > pick 0e01aeef5fa8 2 foo1
   > fold b7389cc4d66e 3 foo2
Mercurial