Mercurial > python-hglib

changeset 188:5609a21fe39a

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
client: fail gracefully on unexpected prompts (issue5516) Right now, if hglib encounters an unexpected prompt, it fails with a rather opaque "unexpected data on required channel 'L'" error message. Furthermore, if subsequently another command is called on the same client instance, both the client and server processes lock up hard (at least on Windows), and the server process rapidly leaks ~2GB of memory. Fix this by responding with an empty string to any unexpected prompt. This will trigger an "abort: response expected" exception from the server, which is easily handled as a CommandError, and subsequent commands sent from the same client work as expected. This doesn't completely resolve bug 5516, as unexpected requests on another required channel (e.g. I) can still cause a lockup. However, it does fix the most common case of an unexpected password prompt.
author Gábor Stefanik <gabor.stefanik@nng.com>
date Tue, 12 Sep 2017 13:16:36 -0400
parents 9062a6b935ad
children 8054e925d9c7
files hglib/client.py
diffstat 1 files changed, 2 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/hglib/client.py	Wed Aug 02 23:43:16 2017 +0900
+++ b/hglib/client.py	Tue Sep 12 13:16:36 2017 -0400
@@ -235,6 +235,8 @@
                 reply = prompt(size, out.getvalue())
                 return reply
             inchannels[b('L')] = func
+        else:
+            inchannels[b('L')] = lambda _: ''
         if input is not None:
             inchannels[b('I')] = input