Mercurial > evolve
changeset 6033:182e2a1dbd1c
topic: drop topicfilter usage from topicrepo.commitctx()
This block of code was introduced in 13313d0cab71, but the commit description
doesn't explain the exact intent of this code.
The fact that the result of other.commitctx() was discarded makes me think that
this block only existed to deal with amends, and it was only useful for code
that was removed earlier in this series.
The only code that's left in commitctx() is adding current topic to
workingcommitctx, and I don't think we need to adjust repo filter for that.
| author | Anton Shestakov <av6@dwimlabs.net> |
|---|---|
| date | Fri, 03 Sep 2021 08:01:58 +0300 |
| parents | 2800aa3c3dbf |
| children | 144d10e74757 |
| files | hgext3rd/topic/__init__.py |
| diffstat | 1 files changed, 0 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/hgext3rd/topic/__init__.py Mon Aug 30 12:05:14 2021 +0300 +++ b/hgext3rd/topic/__init__.py Fri Sep 03 08:01:58 2021 +0300 @@ -484,11 +484,6 @@ return super(topicrepo, self).commit(*args, **kwargs) def commitctx(self, ctx, *args, **kwargs): - topicfilter = topicmap.topicfilter(self.filtername) - if topicfilter != self.filtername: - other = self.filtered(topicmap.topicfilter(self.filtername)) - other.commitctx(ctx, *args, **kwargs) - if isinstance(ctx, context.workingcommitctx): current = self.currenttopic if current: